Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Buf CLI dependency explicit for Dependabot #219

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

drice-buf
Copy link
Contributor

No description provided.

@drice-buf drice-buf requested a review from andrewparmet July 29, 2024 20:18
@drice-buf drice-buf marked this pull request as ready for review July 29, 2024 20:42
@drice-buf drice-buf requested a review from jhump July 29, 2024 20:59
@@ -120,3 +126,9 @@ tasks {
}
}
}

buildConfig {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see it from here, but I just want to make sure this generated constant is internal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generatedBuildConfig.kt is:

package build.buf.gradle

import kotlin.String

internal const val DEFAULT_BUF_VERSION: String = "1.35.0"

@drice-buf drice-buf merged commit c36caf6 into main Jul 29, 2024
8 checks passed
@drice-buf drice-buf deleted the drice/dependabot branch July 29, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants