Make ConfigurationTest success check more robust #221
Conversation
| @@ -44,7 +44,6 @@ class ConfigurationTest : AbstractBufIntegrationTest() { | |||
| } | |||
|
|
|||
| private fun assertSuccess() { | |||
| val result = gradleRunner().withArguments(":tasks").build() | |||
| assertThat(result.output).doesNotContain("cannot use both the protobuf-gradle-plugin and a Buf workspace") | |||
| assertThat(gradleRunner().withArguments(":tasks").build().output.contains("BUILD SUCCESSFUL")) | |||
There was a problem hiding this comment.
I think build() itself verifies success, but this doesn't hurt?
There was a problem hiding this comment.
I guess there's no need for any kind of assert in that case?
There was a problem hiding this comment.
Did you happen to verify that no assertion was needed (like tweaking the config files to expect failure and making sure the test fails)? If so, LGTM!
There was a problem hiding this comment.
Yes, I was able to verify that the test will fail if there is any sort of build error in the resources dir. I also am adding a couple more test cases to nail things down.
drice-buf
force-pushed
the
drice/improve_configuration_test
branch
2 times, most recently
from
0b4c989 to
394f376
Compare
drice-buf
force-pushed
the
drice/improve_configuration_test
branch
from
1e8bf3e to
bd5f6ab
Compare
| @@ -28,23 +28,28 @@ class ConfigurationTest : AbstractBufIntegrationTest() { | |||
| assertFailure() | |||
| } | |||
|
|
|||
| @Test | |||
| fun `project cannot use buf yaml workspaces and the protobuf gradle plugin first`() { | |||
There was a problem hiding this comment.
For naming consistency with the other test cases, maybe "project cannot use buf-work-yaml and the protobuf-gradle-plugin, protobuf applied first"? Or does this new name miss the intent of this test case?
...st/project_cannot_use_buf_yaml_workspaces_and_the_protobuf_gradle_plugin_first/buf.work.yaml
Outdated
Show resolved
Hide resolved
No description provided.