Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added '--rm' to docker command to clean up container after use #38

Merged

Conversation

seanreid-toast
Copy link
Contributor

I didn't see anything that indicated I needed to manually up the version, but if there is, I'll do that before merging.

This patch adds --rm to the arguments passed to Docker when buf is invoked. This cleans up the list of stopped containers on a system.

For testing, I ran the tests included in ./gradle test and watched as containers were created to run buf and were immediately deleted after they terminated. All tests still passed.

@andrewparmet
Copy link
Collaborator

This project is versioned using the semantic versioning plugin.

@andrewparmet andrewparmet merged commit 2ca9712 into bufbuild:main Mar 19, 2022
@andrewparmet
Copy link
Collaborator

Published in version 0.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants