Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if descriptor is nil when filtering unstable packages #213

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

bufdev
Copy link
Member

@bufdev bufdev commented Dec 10, 2020

Fixes #211

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #213 (7c0a30a) into master (1791ed5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   68.98%   69.00%   +0.02%     
==========================================
  Files         232      232              
  Lines       12607    12609       +2     
==========================================
+ Hits         8697     8701       +4     
+ Misses       2931     2930       -1     
+ Partials      979      978       -1     
Impacted Files Coverage Δ
internal/buf/bufcheck/internal/runner.go 78.26% <100.00%> (+0.64%) ⬆️
internal/buf/buffetch/internal/ref_parser.go 92.23% <0.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1791ed5...7c0a30a. Read the comment docs.

@bufdev bufdev merged commit f575896 into master Dec 10, 2020
@bufdev bufdev deleted the fix-211 branch December 10, 2020 21:13
Monirul1 pushed a commit to Monirul1/buf that referenced this pull request Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"buf check breaking" panic with config.IgnoreUnstablePackages and deleted file
1 participant