Add helper for converting token IDs to indexes #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a helper method index to convert an ID into it's index representation for improved readability.
jhump
reviewed
Jan 28, 2025
experimental/token/raw.go
Outdated
Comment on lines
66
to
68
| // Need to invert the bits, because synthetic tokens are | ||
| // stored as negative numbers. | ||
| return ^int(t) |
There was a problem hiding this comment.
This doesn't seem right. What will the index be used for? Treating the indexes of synthetic tokens as in the same domain as indexes of natural tokens feels quite error-prone. I would instead expect separate syntheticIndex and naturalIndex methods, to make sure the caller doesn't screw things up, like indexing into the token stream using the value returned from a synthetic token.
jhump
approved these changes
Jan 30, 2025
mcy
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper method index to convert an ID into it's index representation for improved readability. This is a follow up to #429.