-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to npm #14
Publish to npm #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Looks great to me @djfarrelly . Thanks for getting this up 👍
Quick aside, this isn't necessary for this PR. Might be good to specify minimum versions of node for this package. |
This ensures the -V version flag always returns the correct version without requiring the developer to manually update this.
2 great ideas @kiriappeee!
@kiriappeee, do you have an npm username? I want to add you to our |
Purpose
The binary executable is great, but using
npm
is an easier way to consume, upgrade and publish updates to this package. Package on npmThis also closes #3.
Background
The binary method felt the most usable when this package was written in golang and we didn't want to use npm as a delivery method. We used
pkg
before for other binaries (buffer-dev) because we wanted them to be more easily usable for non-developers, but since this is a developer tool, I think it's ok to assume everyone on the engineering team has node and npm installed 😄Review
Hey @kiriappeee, I was thinking of making another addition to this CLI and thought of this idea. We could continue to build + distribute the binary, but this might be simpler for folks on the team to download the binary off of Github and move it into their PATH. What do you think?