-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make event.unhandled overridable for JVM errors #1025
Merged
fractalwrench
merged 1 commit into
integration/road-732-unhandled-override
from
PLAT-5489/unhandled-override-jvm
Dec 9, 2020
Merged
Make event.unhandled overridable for JVM errors #1025
fractalwrench
merged 1 commit into
integration/road-732-unhandled-override
from
PLAT-5489/unhandled-override-jvm
Dec 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
7dfab9c
to
4ed8f7a
Compare
event.unhandled
overridable for JVM errors
event.unhandled
overridable for JVM errors4ed8f7a
to
ea66407
Compare
tomlongridge
reviewed
Dec 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be a couple of MR changes - is that deliberate? (including some sort of change on features/fixtures/mazerunner/gradlew)
bugsnag-android-core/src/main/java/com/bugsnag/android/DeliveryDelegate.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/test/java/com/bugsnag/android/EventFacadeTest.java
Show resolved
Hide resolved
ea66407
to
abc66f9
Compare
Addressed inline review comments. There are two parts to the mazerunner changes which are intentional:
|
tomlongridge
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This makes it possible to override the
unhandled
property for JVM errors. This allows users to discard certain events from contributing to the stability score.Changeset
HandledState
toSeverityReason
for greater alignment with notifier specEvent
which allows altering theunhandled
stateunhandled
has been changed,unhandledOverridden
is serialized in the JSON payloadDeliveryDelegate
so that it caches unhandled errors even if a user has set theirunhandled
state tofalse
Testing
Updated and added to existing unit test coverage for
unhandled
state serialization. Added new E2E tests to assert thatunhandled
can be overwritten both ways, which have been run locally.