Root detection: check whether su binary exists #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-6105/check-su-exists
branch
from
e869899 to
a12fe2d
Compare
fractalwrench
changed the title
fractalwrench
force-pushed
the
PLAT-6105/check-su-exists
branch
from
a12fe2d to
ed18cc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds code to check whether the su binary exists. If the binary does exist then it's a good indication that the device has been rooted.
Changeset
Added code to run
which suand check the command output is non-empty.Testing
Added unit tests to verify the function handles edge cases around IOExceptions etc. Additionally tested this check on a few devices to confirm the results are useful: