Perform root detection on a background thread #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-6109/bg-root-detection
branch
from
ea21c71 to
9d04c79
Compare
fractalwrench
changed the base branch from
next
to
integration/road-989-root-detection
fractalwrench
force-pushed
the
PLAT-6109/bg-root-detection
branch
from
9d04c79 to
a4d23fb
Compare
twometresteve
approved these changes
Mar 19, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/DeviceDataCollector.kt
Outdated
Show resolved
Hide resolved
…ataCollector.kt Co-authored-by: Steve Kirkland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The implementation should detect root on a background thread when Bugsnag initialises to reduce impact on the main thread. If root detection is halfway complete when an error is captured, then the notifier will block using a
Futureuntil the root detection is complete.Changeset
Invoked root detection on a background thread which returns a
Future<Boolean>. This will execute immediately in the background, but if an error occurs before root detection can complete, theFuturewill block usingget()until the value is available for use in theDevicepayload.If the task can't be scheduled or is interrupted with an exception then
falsewill be used as a default value. (This is a highly improbable scenarios as the executor is very unlikely to be saturated with tasks during initialization.)Testing
Manually verified that the root detection occurs on a non-main thread.