Optimize execution of callbacks #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-6752/callback-optimization
branch
from
a33e068 to
80dbe60
Compare
fractalwrench
force-pushed
the
PLAT-6752/callback-optimization
branch
from
80dbe60 to
2319487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Bugsnag supplies the ability to set callbacks for when breadcrumbs are added, and when an error or session are captured. Breadcrumbs/errors in particular can be captured many times per second.
By default no callbacks are set. This changeset optimizes the default behaviour by performing an
isEmpty()check before running the callbacks, which avoids construction of an iterator each time. For the addition of ~1000 breadcrumbs this saves ~3ms in the default case and has negligible impact when callbacks are set.Testing
Verified by profiling the changes in an example app with no callbacks set and observing
runOnBreadcrumbTasks():