Avoid unnecessary BroadcastReceiver registration for monitoring device orientation #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
PLAT-6763/orientation-tracking
branch
2 times, most recently
from
035d4d3 to
b683654
Compare
fractalwrench
force-pushed
the
PLAT-6763/orientation-tracking
branch
from
b683654 to
702283c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoids unnecessary registration of a
BroadcastReceiverthat is used to monitor the device's orientation. The changeset implements theComponentCallbacksinstead to track when the orientation changes, and updatesDeviceDataCollectorso that it holds this value as state.Testing
Added to existing unit tests and verified manually that breadcrumbs are still automatically recorded for orientation changes.