Handle NullPointerExceptions from getActiveNetworkInfo #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-6860/fix-connectivity-manager-exception
branch
from
28580a5 to
85ca690
Compare
…tworkInfo as null
lemnik
force-pushed
the
PLAT-6860/fix-connectivity-manager-exception
branch
from
85ca690 to
1488b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Handle cases where
ConnectivityManager.getActiveNetworkInfothrows a NullPointerException instead of returningnull(as expected).Design
Treat the
NullPointerExceptions asnullvalues, and leave all other exceptions to propagate as normal to avoid breaking existing error-handling logic.Testing
Tested using mocking in unit tests as this has only been seen in very limited real-world situations.