Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle interrupt when shutting down executors #1315

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Handle interrupt when shutting down executors #1315

merged 1 commit into from
Jul 8, 2021

Conversation

fractalwrench
Copy link
Contributor

Goal

Handles an InterruptedException which can be thrown when shutting down bugsnag's executors.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench force-pushed the PLAT-6884/catch-interrupted-exception branch from 46cfdfd to 2edc73c Compare July 8, 2021 14:09
@fractalwrench fractalwrench requested a review from lemnik July 8, 2021 14:09
lemnik
lemnik approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 1db6c69 into next Jul 8, 2021
@fractalwrench fractalwrench deleted the PLAT-6884/catch-interrupted-exception branch July 8, 2021 14:38
@djskinner djskinner mentioned this pull request Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemnik lemnik lemnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @lemnik