Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow max threads to be configured via the manifest #1655

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Allow max threads to be configured via the manifest #1655

merged 1 commit into from
Apr 14, 2022

Conversation

kstenerud
Copy link
Contributor

Goal

The new maxReportedThreads config option was not settable via the manifest. This PR adds that capability.

Testing

New tests to verify manifest settings.

@kstenerud kstenerud requested a review from lemnik April 14, 2022 10:47
lemnik
lemnik approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@lemnik lemnik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Might need a Changelog entry as well?

@kstenerud kstenerud merged commit baef56a into next Apr 14, 2022
@kstenerud kstenerud deleted the PLAT-8170-max-threads branch April 14, 2022 12:18
@lemnik lemnik mentioned this pull request Apr 28, 2022
Merged
@gingerbenw gingerbenw mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemnik lemnik lemnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kstenerud @lemnik