Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update AGP and compileSdk versions #2123

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions .buildkite/pipeline.full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -901,3 +901,68 @@ steps:
docker-compose#v4.7.0:
no-cache: true
run: android-publisher

- label: ':bitbar: Android 14 NDK r21 smoke tests'
depends_on: "fixture-r21"
timeout_in_minutes: 30
plugins:
artifacts#v1.9.0:
download:
- "build/fixture-r21-url.txt"
- "build/fixture-r21/*"
upload:
- "maze_output/failed/**/*"
- "maze_output/metrics.csv"
docker-compose#v4.7.0:
pull: maze-runner
run: maze-runner
service-ports: true
command:
- "features/smoke_tests"
- "--exclude=features/smoke_tests/01_anr.feature"
- "--app=@build/fixture-r21-url.txt"
- "--appium-version=1.22"
- "--no-tunnel"
- "--aws-public-ip"
- "--farm=bb"
- "--device=ANDROID_14"
test-collector#v1.10.2:
files: "reports/TEST-*.xml"
format: "junit"
branch: "^master|next$$"
env:
TEST_FIXTURE_SYMBOL_DIR: "build/fixture-r21"
concurrency: 25
concurrency_group: 'bitbar'
concurrency_method: eager

- label: ':browserstack: Android 14 NDK r21 ANR smoke tests'
depends_on: "fixture-r21"
timeout_in_minutes: 30
plugins:
artifacts#v1.9.0:
download:
- "build/bs-fixture-r21-url.txt"
- "build/fixture-r21/*"
upload:
- "maze_output/failed/**/*"
- "maze_output/metrics.csv"
docker-compose#v4.7.0:
pull: maze-runner
run: maze-runner
service-ports: true
command:
- "features/smoke_tests/01_anr.feature"
- "--app=@build/bs-fixture-r21-url.txt"
- "--appium-version=1.22.0"
- "--farm=bs"
- "--device=ANDROID_14"
test-collector#v1.10.2:
files: "reports/TEST-*.xml"
format: "junit"
branch: "^master|next$$"
env:
TEST_FIXTURE_SYMBOL_DIR: "build/fixture-r21"
concurrency: 5
concurrency_group: 'browserstack-app'
concurrency_method: eager
22 changes: 10 additions & 12 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -598,13 +598,13 @@ steps:
concurrency_group: 'browserstack-app'
concurrency_method: eager

- label: ':bitbar: Android 14 NDK r21 smoke tests'
- label: ':browserstack: Android 15 NDK r21 smoke tests'
depends_on: "fixture-r21"
timeout_in_minutes: 30
plugins:
artifacts#v1.9.0:
download:
- "build/fixture-r21-url.txt"
- "build/bs-fixture-r21-url.txt"
- "build/fixture-r21/*"
upload:
- "maze_output/failed/**/*"
Expand All @@ -616,23 +616,21 @@ steps:
command:
- "features/smoke_tests"
- "--exclude=features/smoke_tests/01_anr.feature"
- "--app=@build/fixture-r21-url.txt"
- "--appium-version=1.22"
- "--no-tunnel"
- "--aws-public-ip"
- "--farm=bb"
- "--device=ANDROID_14"
- "--app=@build/bs-fixture-r21-url.txt"
- "--appium-version=1.22.0"
- "--farm=bs"
- "--device=ANDROID_15"
test-collector#v1.10.2:
files: "reports/TEST-*.xml"
format: "junit"
branch: "^master|next$$"
env:
TEST_FIXTURE_SYMBOL_DIR: "build/fixture-r21"
concurrency: 25
concurrency_group: 'bitbar'
concurrency: 5
concurrency_group: 'browserstack-app'
concurrency_method: eager

- label: ':browserstack: Android 14 NDK r21 ANR smoke tests'
- label: ':browserstack: Android 15 NDK r21 ANR smoke tests'
depends_on: "fixture-r21"
timeout_in_minutes: 30
plugins:
Expand All @@ -652,7 +650,7 @@ steps:
- "--app=@build/bs-fixture-r21-url.txt"
- "--appium-version=1.22.0"
- "--farm=bs"
- "--device=ANDROID_14"
- "--device=ANDROID_15"
test-collector#v1.10.2:
files: "reports/TEST-*.xml"
format: "junit"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ env:
jobs:
analyze:
name: Analyze
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-22.04' }}
permissions:
actions: read
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scorecard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
# Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
# format to the repository Actions tab.
- name: "Upload artifact"
uses: actions/upload-artifact@97a0fba1372883ab732affbe8f94b823f91727db # v3.pre.node20
uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0
with:
name: SARIF file
path: results.sarif
Expand Down
4 changes: 2 additions & 2 deletions features/fixtures/mazerunner/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ apply plugin: "io.gitlab.arturbosch.detekt"
apply plugin: "org.jlleitschuh.gradle.ktlint"

android {
compileSdk 34
compileSdk 35
ndkVersion parent.ext.ndkVersion

defaultConfig {
minSdkVersion 17
targetSdkVersion 34
versionCode 34
versionCode 1
versionName "1.1.14"
manifestPlaceholders = [
// omit any of the following placeholders to use the default values
Expand Down
2 changes: 1 addition & 1 deletion features/fixtures/mazerunner/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ buildscript {
dependencies {
def agpVersion = project.hasProperty("USE_AGP_VERSION")
? project.property("USE_AGP_VERSION")
: "8.5.0"
: "8.6.1"

project.logger.lifecycle("Using AGP $agpVersion")
classpath "com.android.tools.build:gradle:$agpVersion"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ apply plugin: "io.gitlab.arturbosch.detekt"
apply plugin: "org.jlleitschuh.gradle.ktlint"

android {
compileSdkVersion 31
compileSdkVersion 35
ndkVersion parent.ext.ndkVersion

defaultConfig {
minSdkVersion 16
minSdkVersion 17
}

buildTypes {
Expand Down
4 changes: 2 additions & 2 deletions features/fixtures/mazerunner/cxx-scenarios/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ apply plugin: "io.gitlab.arturbosch.detekt"
apply plugin: "org.jlleitschuh.gradle.ktlint"

android {
compileSdkVersion 31
compileSdkVersion 35
ndkVersion parent.ext.ndkVersion

defaultConfig {
minSdkVersion 14
minSdkVersion 17
}

buildTypes {
Expand Down
2 changes: 1 addition & 1 deletion features/fixtures/mazerunner/jvm-scenarios/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ apply plugin: "io.gitlab.arturbosch.detekt"
apply plugin: "org.jlleitschuh.gradle.ktlint"

android {
compileSdkVersion 31
compileSdkVersion 35

defaultConfig {
minSdkVersion 17
Expand Down
2 changes: 1 addition & 1 deletion features/full_tests/internal_error_reports.feature
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Feature: Cached Error Reports
And the event "app.releaseStage" equals "mazerunner"
And the event "app.type" equals "android"
And the event "app.version" equals "1.1.14"
And the event "app.versionCode" equals 34
And the event "app.versionCode" equals 1
And the error payload field "events.0.app.duration" is an integer
And the error payload field "events.0.app.durationInForeground" is an integer
And the event "app.inForeground" is true
Expand Down
2 changes: 1 addition & 1 deletion features/full_tests/load_configuration.feature
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Feature: Loading values into the configuration
And the event "app.releaseStage" is not null
And the event "metaData.test.foo" equals "bar"
And the event "metaData.test.filter_me" equals "foobar"
And the event "app.versionCode" equals 34
And the event "app.versionCode" equals 1
And the event "app.buildUUID" is not null
And the event "app.version" equals "1.1.14"
And the event "app.type" is null
Expand Down
2 changes: 1 addition & 1 deletion features/smoke_tests/01_anr.feature
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Feature: ANR smoke test
And the event "app.releaseStage" equals "mazerunner"
And the event "app.type" equals "android"
And the event "app.version" equals "1.1.14"
And the event "app.versionCode" equals 34
And the event "app.versionCode" equals 1
And the error payload field "events.0.app.duration" is an integer
And the error payload field "events.0.app.durationInForeground" is an integer
And the event "app.inForeground" is true
Expand Down
4 changes: 2 additions & 2 deletions features/smoke_tests/02_handled.feature
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Feature: Handled smoke tests
And the event "app.releaseStage" equals "mazerunner"
And the event "app.type" equals "android"
And the event "app.version" equals "1.1.14"
And the event "app.versionCode" equals 34
And the event "app.versionCode" equals 1
And the error payload field "events.0.app.duration" is an integer
And the error payload field "events.0.app.durationInForeground" is an integer
And the event "app.inForeground" is true
Expand Down Expand Up @@ -196,7 +196,7 @@ Feature: Handled smoke tests
And the event "app.releaseStage" equals "mazerunner"
And the event "app.type" equals "android"
And the event "app.version" equals "1.1.14"
And the event "app.versionCode" equals 34
And the event "app.versionCode" equals 1
And the error payload field "events.0.app.duration" is an integer
And the error payload field "events.0.app.durationInForeground" is an integer
And the event "app.inForeground" is true
Expand Down
2 changes: 1 addition & 1 deletion features/smoke_tests/03_sessions.feature
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Feature: Session functionality smoke tests
And the session payload field "app.releaseStage" equals "mazerunner"
And the session payload field "app.type" equals "android"
And the session payload field "app.version" equals "1.1.14"
And the session payload field "app.versionCode" equals 34
And the session payload field "app.versionCode" equals 1

# Device data
And the session payload field "device.cpuAbi" is a non-empty array
Expand Down
2 changes: 1 addition & 1 deletion features/smoke_tests/04_unhandled.feature
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Feature: Unhandled smoke tests
And the event "app.releaseStage" equals "mazerunner"
And the event "app.type" equals "android"
And the event "app.version" equals "1.1.14"
And the event "app.versionCode" equals 34
And the event "app.versionCode" equals 1
And the error payload field "events.0.app.duration" is an integer
And the error payload field "events.0.app.durationInForeground" is an integer
And the event "app.inForeground" is true
Expand Down
2 changes: 1 addition & 1 deletion features/steps/android_steps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def wait_for_app_state(expected_state)
And the error payload field "events.0.app.releaseStage" is not null
And the error payload field "events.0.app.type" equals "android"
And the error payload field "events.0.app.version" is not null
And the error payload field "events.0.app.versionCode" equals 34
And the error payload field "events.0.app.versionCode" equals 1
And the error payload field "events.0.device.id" is not null
And the error payload field "events.0.device.locale" is not null
And the error payload field "events.0.device.manufacturer" is not null
Expand Down