-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support changing NDK Event's api key in OnErrorCallback #964
Conversation
Android notifier sizes
Generated by 🚫 Danger |
9a48a35
to
646859d
Compare
47cf5eb
to
1c081c6
Compare
1c081c6
to
349815a
Compare
Updated to avoid encoding the apiKey in the NDK filename. Retested by setting the apiKey in an example app and triggering an NDK crash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think the changeset details in the PR description just need a slight amendment now the NDK file name format has not changed?
Goal
Adds support for changing the apiKey on events from the NDK layer. #928 added equivalent functionality for JVM events.
Changeset
The changeset consists mainly of five alterations:
StateEvent.Install
messagebugsnag_event
struct, which requires a migration for legacy persisted structsdeliverPendingReports()
and pass to the JVM layer along with the deserialized event payloadTesting
Existing unit and integration tests have been updated to match the new assertions. New test cases have also been added for additional coverage and to verify the NDK migration.
Manual testing also covered:
bugsnag_event
struct are delivered