Flush persisted sessions on launch and on connectivity changes #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-5331/session-flush
branch
from
12dfc60 to
f678337
Compare
Android notifier sizes
Generated by 🚫 Danger |
fractalwrench
force-pushed
the
PLAT-5331/session-flush
branch
from
f678337 to
996a543
Compare
|
Test failures on Android 6 and 7 due to current blocking device farm issue. |
tomlongridge
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Session payloads are persisted on disk if a request to bugsnag was unsuccessful. Delivery of these is only attempted currently when a new session is captured. To increase the speed with which requests are received, delivery should also be attempted on
Clientinitialization` and whenever connectivity changes.Changeset
Called
flushAsync()in the client constructor and connectivity change callback. Access to this method is guarded by a Semaphore so concurrent calls will be ignored.Testing
Relied on existing E2E tests, and manually verified that an undelivered session is now delivered when the client is launched or the connectivity is regained.