[PLAT-6635] Verify BugsnagStatic usability during CI #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
force-pushed
the
nickdowell/static-linking-ci-check
branch
from
24140ba to
64fd2f0
Compare
nickdowell
force-pushed
the
nickdowell/static-linking-ci-check
branch
from
64fd2f0 to
e53df1a
Compare
kattrali
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To verify that
libBugsnagStatic.acan be used by apps without requiring the-ObjClinker flag.Relates to #1098
Changeset
libBugsnagStatic.ais now used when building the iOS test fixture. Allimport Bugsnagstatements in Swift code needed to be removed since in this configuration Bugsnag is not built as a separate module.The macOS fixture now links Bugsnag as a framework via CocoaPods.
Testing
Verified locally and on CI.
Tested these changes against v6.9.2 and saw an immediate crash due to
unrecognized selector sent to instancewhen starting Bugsnag.