[PLAT-7591] Feature flags #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
reviewed
Nov 16, 2021
kstenerud
approved these changes
Nov 16, 2021
kattrali
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Implements feature flags - a formal way to express which optional features / experiments have been enabled in an app session.
Design
Follows the Engineering Design.
Changeset
BugsnagFeatureFlagclass andBugsnagFeatureFlagStoreprotocol.BSGFeatureFlagStore.mimplements the basic manipulation and serialization of feature flags.BugsnagClientpersists feature flags using the existing "state" metadata mechanism (also used to persist app, context and user info.)Testing
Covered by new unit tests and amended E2E scenarios.