Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-7591] Feature flags #1279

Merged
merged 17 commits into from
Jan 12, 2022
Merged

[PLAT-7591] Feature flags #1279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1f7f544
Update maze-runner to v6.4.0
nickdowell Nov 11, 2021
722d55e
Add BugsnagFeatureFlag class
nickdowell Nov 11, 2021
e60ed74
Implement BSGFeatureFlagStore
nickdowell Nov 11, 2021
41b0712
Add BugsnagFeatureFlagStore
nickdowell Nov 11, 2021
c483a72
Event FeatureFlagStore conformance
nickdowell Nov 11, 2021
d7edf09
Configuration FeatureFlagStore conformance
nickdowell Nov 11, 2021
61433ef
Client FeatureFlagStore conformance
nickdowell Nov 11, 2021
d4121af
Rename feature flags serialization functions
nickdowell Nov 12, 2021
3ac99f4
Add feature flags to events
nickdowell Nov 12, 2021
a439ef0
Pipeline: Fix exclusionary regexes to only exclude feature files
Cawllec Nov 15, 2021
473a6d6
Merge branch 'integration/feature-flags' into nickdowell/feature-flags
nickdowell Dec 20, 2021
ec60639
Merge pull request #1227 from bugsnag/nickdowell/feature-flags
nickdowell Dec 21, 2021
88f5596
Fix iOS 14 E2E tests
nickdowell Dec 22, 2021
b3bd116
Replace BugsnagStateEvent with BSGClientObserver
nickdowell Dec 21, 2021
6d7f9cf
Add feature flags to BSGClientObserver
nickdowell Dec 21, 2021
535705c
Merge branch 'next' into integration/feature-flags
nickdowell Jan 11, 2022
536a772
Add feature flags changelog entry
nickdowell Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .buildkite/pipeline.full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ steps:
- "--device=IOS_14"
- "--appium-version=1.17.0"
- "--fail-fast"
- "--exclude=features/[h-z].*.feature"
- "--exclude=features/[h-z].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand All @@ -52,7 +52,7 @@ steps:
- "--device=IOS_14"
- "--appium-version=1.17.0"
- "--fail-fast"
- "--exclude=features/[a-g].*.feature"
- "--exclude=features/[a-g].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down Expand Up @@ -80,7 +80,7 @@ steps:
- "--device=IOS_13"
- "--appium-version=1.17.0"
- "--fail-fast"
- "--exclude=features/[h-z].*.feature"
- "--exclude=features/[h-z].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down Expand Up @@ -109,7 +109,7 @@ steps:
- "--device=IOS_13"
- "--appium-version=1.17.0"
- "--fail-fast"
- "--exclude=features/[a-g].*.feature"
- "--exclude=features/[a-g].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down Expand Up @@ -138,7 +138,7 @@ steps:
- "--device=IOS_12"
- "--appium-version=1.17.0"
- "--fail-fast"
- "--exclude=features/[h-z].*.feature"
- "--exclude=features/[h-z].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down Expand Up @@ -167,7 +167,7 @@ steps:
- "--device=IOS_12"
- "--appium-version=1.17.0"
- "--fail-fast"
- "--exclude=features/[a-g].*.feature"
- "--exclude=features/[a-g].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down Expand Up @@ -198,7 +198,7 @@ steps:
- "--device=IOS_11_0_IPHONE_8_PLUS"
- "--appium-version=1.8.0"
- "--fail-fast"
- "--exclude=features/[h-z].*.feature"
- "--exclude=features/[h-z].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down Expand Up @@ -229,7 +229,7 @@ steps:
- "--device=IOS_11_0_IPHONE_8_PLUS"
- "--appium-version=1.8.0"
- "--fail-fast"
- "--exclude=features/[a-g].*.feature"
- "--exclude=features/[a-g].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down
9 changes: 4 additions & 5 deletions .buildkite/pipeline.quick.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ steps:
- "--device=IOS_15"
- "--appium-version=1.21.0"
- "--fail-fast"
- "--exclude=features/[h-z].*.feature"
- "--exclude=features/[h-z].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down Expand Up @@ -182,7 +182,7 @@ steps:
- "--device=IOS_15"
- "--appium-version=1.21.0"
- "--fail-fast"
- "--exclude=features/[a-g].*.feature"
- "--exclude=features/[a-g].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down Expand Up @@ -211,7 +211,7 @@ steps:
- "--device=IOS_10"
- "--appium-version=1.8.0"
- "--capabilities={\"browserstack.networkLogs\":\"true\"}"
- "--exclude=features/[h-z].*.feature"
- "--exclude=features/[h-z].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down Expand Up @@ -239,8 +239,7 @@ steps:
- "--farm=bs"
- "--device=IOS_10"
- "--appium-version=1.8.0"
- "--capabilities={\"browserstack.networkLogs\":\"true\"}"
- "--exclude=features/[a-g].*.feature"
- "--exclude=features/[a-g].*.feature$"
- "--order=random"
concurrency: 9
concurrency_group: browserstack-app
Expand Down
88 changes: 60 additions & 28 deletions Bugsnag.xcodeproj/project.pbxproj
View file
Open in desktop

Large diffs are not rendered by default.

34 changes: 34 additions & 0 deletions Bugsnag/Bugsnag.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,40 @@ + (void)addRuntimeVersionInfo:(NSString *)info
}
}

// =============================================================================
// MARK: - <BugsnagFeatureFlagStore>
// =============================================================================

+ (void)addFeatureFlagWithName:(NSString *)name variant:(nullable NSString *)variant {
if ([self bugsnagStarted]) {
[self.client addFeatureFlagWithName:name variant:variant];
}
}

+ (void)addFeatureFlagWithName:(NSString *)name {
if ([self bugsnagStarted]) {
[self.client addFeatureFlagWithName:name];
}
}

+ (void)addFeatureFlags:(NSArray<BugsnagFeatureFlag *> *)featureFlags {
if ([self bugsnagStarted]) {
[self.client addFeatureFlags:featureFlags];
}
}

+ (void)clearFeatureFlagWithName:(NSString *)name {
if ([self bugsnagStarted]) {
[self.client clearFeatureFlagWithName:name];
}
}

+ (void)clearFeatureFlags {
if ([self bugsnagStarted]) {
[self.client clearFeatureFlags];
}
}

// =============================================================================
// MARK: - <BugsnagClassLevelMetadataStore>
// =============================================================================
Expand Down
29 changes: 29 additions & 0 deletions Bugsnag/BugsnagFeatureFlag.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
//
// BugsnagFeatureFlag.m
// Bugsnag
//
// Created by Nick Dowell on 11/11/2021.
// Copyright © 2021 Bugsnag Inc. All rights reserved.
//

#import "BugsnagFeatureFlag.h"

@implementation BugsnagFeatureFlag

+ (instancetype)flagWithName:(NSString *)name {
return [[BugsnagFeatureFlag alloc] initWithName:name variant:nil];
}

+ (instancetype)flagWithName:(NSString *)name variant:(nullable NSString *)variant {
return [[BugsnagFeatureFlag alloc] initWithName:name variant:variant];
}

- (instancetype)initWithName:(NSString *)name variant:(nullable NSString *)variant {
if ((self = [super init])) {
_name = [name copy];
_variant = [variant copy];
}
return self;
}

@end
16 changes: 12 additions & 4 deletions Bugsnag/Client/BugsnagClient+Private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,16 @@

NS_ASSUME_NONNULL_BEGIN

typedef NS_ENUM(NSInteger, BSGClientObserverEvent) {
BSGClientObserverAddFeatureFlag, // value: BugsnagFeatureFlag
BSGClientObserverClearFeatureFlag, // value: NSString
BSGClientObserverUpdateContext, // value: NSString
BSGClientObserverUpdateMetadata, // value: BugsnagMetadata
BSGClientObserverUpdateUser, // value: BugsnagUser
};

typedef void (^ BSGClientObserver)(BSGClientObserverEvent event, _Nullable id value);

@interface BugsnagClient ()

#pragma mark Properties
Expand Down Expand Up @@ -114,12 +124,12 @@ NS_ASSUME_NONNULL_BEGIN

@property (nonatomic) BugsnagUser *user;

@property (nullable, nonatomic) BSGClientObserver observer; // Used in BugsnagReactNative

#pragma mark Methods

- (void)addBreadcrumbWithBlock:(void (^)(BugsnagBreadcrumb *))block;

- (void)addObserverWithBlock:(BugsnagObserverBlock)block; // Used in BugsnagReactNative

- (void)addRuntimeVersionInfo:(NSString *)info withKey:(NSString *)key;

- (NSDictionary *)collectAppWithState; // Used in BugsnagReactNative
Expand All @@ -138,8 +148,6 @@ NS_ASSUME_NONNULL_BEGIN

- (void)notifyInternal:(BugsnagEvent *)event block:(nullable BugsnagOnErrorBlock)block;

- (void)removeObserverWithBlock:(BugsnagObserverBlock)block; // Used in BugsnagReactNative

- (void)start;

@end
Expand Down
Loading