[PLAT-5354] Add Bugsnag-Integrity HTTP header #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
approved these changes
Nov 11, 2020
kattrali
approved these changes
Nov 11, 2020
nickdowell
force-pushed
the
nickdowell/integrity-header
branch
from
7ca1c2c to
8d59172
Compare
nickdowell
force-pushed
the
nickdowell/integrity-header
branch
from
8d59172 to
42ff37f
Compare
# Conflicts: # Bugsnag/Delivery/BugsnagApiClient.h # Bugsnag/Delivery/BugsnagApiClient.m
nickdowell
force-pushed
the
nickdowell/integrity-header
branch
from
42ff37f to
0f32e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Implements the new
Bugsnag-Integrityheader as specified in design for ROAD-857Design
Apple's CommonCrypto framework is used to generate the SHA1 hash.
Testing
Added a unit test to validate hash computation against expected output, using the
shasumcommand line utility to generate the expected output.Maze runner has been updated to verify the correctness of the header, so E2E test will fail if incorrect values are sent.