Officially support Go 1.12 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable testing of branch and PR builds against Go's latest development branch. This should be done on a scheduled basis instead, but this is too strict for PRs and branches.
Tests: Run tests against latest release of Go
CodeHex
approved these changes
Mar 18, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the current version of the notifier should work just fine against Go 1.12, the tests are failing due to some overly aggressive test assertions. This branch fixes broken tests and runs CI against Go 1.12.
The issue was that tests were asserting against which stackframes we saw internally from Go itself, which we have been lucky with for versions 1.7-1.11, but has had changes in Go 1.12. These were a bit too rigid, and instead we should just check that the stack frames do appear, but be a bit more relaxed as to where in the stack they are. I've created a utility function to do just that.