Rewrite maze runner tests from v1 to v9 #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Then I wait to receive a request | ||
| And the request is a valid error report with api key "a35a2a72bd230ac0aa0f52715bbdc6aa" | ||
| Given I set environment variable "BUGSNAG_AUTO_CAPTURE_SESSIONS" to "false" | ||
| When I start the service "app" |
There was a problem hiding this comment.
It looks like every test scenario uses this step. Could it be moved to a Before hook to avoid repetition, or would that mess up setting of environment variables to control the test scenarios?
|
I've raised a couple of basic comments, but the diff is far too complex and large for me to feel comfortable reviewing it effectively. There are also merge conflicts anyway to resolve. Could the changes be reconstructed into a series of much smaller PRs into an integration branch, even if the tests don't all pass until the end of that integration branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Tests written on maze-runner v1 stopped working for newer github action's images.
Changeset
Merged three test apps into one, added command pattern, updated Dockerfile to use GO111MODULES.
Testing
Rewritten maze-runner tests.