Migrate version information to device.runtimeVersions #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeforeSendSession is invoked immediately before a SessionPayload is queued for delivery. This allows for the mutation of the payload if required by different frameworks (e.g. Spring). This is currently an internal API and not accessible to users.
bengourley
reviewed
Apr 23, 2019
There was a problem hiding this comment.
I feel like the retrieveRuntimeVersionsMap method's functionality should be moved to the report class. That way it can have a name that is more indicative of what it's going to do.
There may be a good reason not to do this that I'm not aware of. If so I think the method could just do with a better name. It seems odd to have "map" in the name when that information is provided by the type system.
fractalwrench
dismissed
Cawllec’s stale review
Dismissing to avoid review confusion as per slack conversation
bengourley
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We should collect the following information in the
device.runtimeVersionssection of the payload:Changeset
device.runtimeNametodevice.runtimeVersions.javaTypedevice.runtimeVersiontodevice.runtimeVersions.javaVersiondevice.metaData.springVersiontodevice.runtimeVersions.springFrameworkdevice.metaData.springBootVersiontodevice.runtimeVersions.springBootBeforeSendSessionscallback which is invoked immediately before session delivery and allows mutation of the payloadTests
Ran existing tests, and added new mazerunner scenarios to verify that version info is included in both errors/sessions for a plain, Spring, and Spring Boot app.