Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-4691] Fix Expo config type definition #1010

Merged
merged 3 commits into from
Aug 21, 2020
Merged

[PLAT-4691] Fix Expo config type definition #1010

merged 3 commits into from
Aug 21, 2020

Conversation

bengourley
Copy link
Contributor

Fixes #953.

The config object does not require the apiKey on Expo, since it may be supplied in app.json.

@bengourley bengourley requested a review from djskinner August 20, 2020 14:36
@bengourley bengourley requested a review from a team as a code owner August 20, 2020 14:36
@bengourley bengourley force-pushed the bengourley/expo-start-type-def branch from e257ad7 to 29a196f Compare August 20, 2020 14:36
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Aug 20, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against 1919093

djskinner
djskinner approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@djskinner djskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested manually but am confident the change and corresponding type test will work as expected

@bengourley bengourley merged commit 375942b into next Aug 21, 2020
@bengourley bengourley deleted the bengourley/expo-start-type-def branch August 21, 2020 10:48
@imjoehaines imjoehaines mentioned this pull request Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

@twometresteve twometresteve twometresteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expo/TypeScript: apiKey required when calling Bugsnag.start()
4 participants
@bengourley @bugsnagbot @djskinner @twometresteve