Tests: Update regexes and include MR fix #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
approved these changes
Feb 16, 2021
| When I input a return interactively | ||
| Then I wait for the shell to output a match for the regex "@bugsnag/source-maps dependency is installed" to stdout | ||
| Then I wait for the shell to output a match for the regex "@bugsnag\/source-maps dependency is installed" to stdout |
There was a problem hiding this comment.
Sorry to be annoying, but these forward slashes don't actually need to be escaped because of how the regex is constructed, e.g.
irb(main):001:0> a = Regexp.new("http:\/\/example\.com")
irb(main):002:0> a.match? "http://example.com"
=> true
irb(main):003:0> b = Regexp.new("http://example\.com")
irb(main):004:0> b.match? "http://example.com"
=> trueThe URLs especially get a bit hard to read with the escaping
twometresteve
force-pushed
the
tests/rn-cli-mr-update
branch
from
13d6032 to
a55b0ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Updates the regex's added in the react-native CLI maze-runner update #1293. In addition updates the version of Maze-runner required to apply latest fixes.