Bugsnag.lastRunInfo for Electron #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 41.24 kB |
12.71 kB |
| After | 41.24 kB |
12.71 kB |
| ± | No change | No change |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron-filestore/filestore.js | 81.08% (-12.57%) |
57.89% (-26.73%) |
84% (-7.3%) |
81.08% (-12.57%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/notifier.js | 46.88% (-6.69%) |
31.25% (-4.46%) |
20% (-13.33%) |
44.44% (-5.56%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-app/app.js | 98.41% (-1.59%) |
86.67% (-1.79%) |
100% (+0%) |
98.51% (-1.49%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 82.05%(-0.24%) | 71.44%(-0.26%) | 83.52%(-0.26%) | 81.05%(-0.21%) |
lemnik
force-pushed
the
PLAT-6151/electron-last-run-info
branch
from
8609794 to
0404fe5
Compare
lemnik
force-pushed
the
PLAT-6151/electron-last-run-info
branch
from
6d2d498 to
7696349
Compare
lemnik
force-pushed
the
PLAT-6151/electron-last-run-info
branch
from
7696349 to
336bd53
Compare
imjoehaines
reviewed
Jul 29, 2021
packages/plugin-electron-deliver-minidumps/deliver-minidumps.js
Outdated
Show resolved
Hide resolved
packages/plugin-electron-client-state-persistence/test/client-state-persistence.test.ts
Outdated
Show resolved
Hide resolved
lemnik
force-pushed
the
PLAT-6151/electron-last-run-info
branch
10 times, most recently
from
92a8252 to
bf478f8
Compare
imjoehaines
approved these changes
Aug 3, 2021
…having a default value
lemnik
force-pushed
the
PLAT-6151/electron-last-run-info
branch
from
bf478f8 to
c97af64
Compare
kattrali
approved these changes
Aug 9, 2021
imjoehaines
pushed a commit
that referenced
this pull request
Oct 19, 2021
* feat(electron): lastRunInfo exposes the exit state of the last application run * test(electron): end2end testing for lastRunInfo * fix(electron): free lastRunInfo memory on NativeClient.uninstall * fix(electron): lastRunInfo is now `null` if not available instead of having a default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Expose the last exit status of the application as
Bugsnag.lastRunInfo. This property covers whether the previous application run exited as a crash and whether the crash occurred during launch (and how many consecutive launch-crashes have occurred).Testing
New unit tests and end2end testing included, along with manual testing. The end2end test fixture now includes an option to log the
lastRunInfoas a Breadcrumb - allowing easy access within the existing testing structures.