Don't send minidumps if the endpoint isn't configured #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minidumps endpoint has to remain optional to avoid a breaking change in the config schema. However, if the endpoint is missing we attempt to start delivery and this eventually triggers an error as the URL is 'undefined'
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 41.54 kB |
12.79 kB |
| After | 41.54 kB |
12.79 kB |
| ± | No change | No change |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-deliver-minidumps/deliver-minidumps.js | 50% (+2.63%) |
43.75% (+8.04%) |
33.33% (+0%) |
50.77% (+2.38%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 82.05%(+0.02%) | 71.83%(+0.02%) | 83.26%(+0%) | 81.1%(+0.01%) |
lemnik
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The
minidumpsendpoint has to be optional because we've already shipped endpoint validation that only requiresnotify&sessions. This means we have to handle the case where theminidumpsendpoint is not present as we can't rely on it always being setThis PR adds a check to ensure the minidumps endpoint is set before starting the minidump delivery process and adds
minidumpsas an allowed value in theendpointstype definition