Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-react-navigation: Allow React Navigation v6 as a peer dependency #1691

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

imjoehaines
Copy link
Contributor

@imjoehaines imjoehaines commented Feb 21, 2022

Goal

Allows React Navigation v6 as a peer dependency of @bugsnag/plugin-react-navigation to fix a peer dependency warning. No changes to the plugin are required

Testing

This is tested in the Maze Runner tests:

npm install @react-native-community/masked-view@^0.1 --registry=$REGISTRY_URL
npm install @react-navigation/native@^6.0 --registry=$REGISTRY_URL
npm install @react-navigation/stack@^6.0 --registry=$REGISTRY_URL
npm install react-native-gesture-handler@^2.2 --registry=$REGISTRY_URL
npm install react-native-reanimated@^1.13 --registry=$REGISTRY_URL
npm install [email protected] --registry=$REGISTRY_URL
npm install [email protected] --registry=$REGISTRY_URL

I've not updated the unit tests to run against v6 because it requires a Typescript update, which causes a host of dependency issues

@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 42.85 kB 13.07 kB
After 42.85 kB 13.07 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 292874d

@imjoehaines imjoehaines marked this pull request as ready for review February 21, 2022 16:40
@imjoehaines imjoehaines merged commit ed9b8a9 into next Feb 22, 2022
@imjoehaines imjoehaines deleted the react-navigation-dependency-update branch February 22, 2022 09:08
@imjoehaines imjoehaines mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants