-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not add JCenter dependency when building RN apps #1856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1103a0d
to
7b0eb91
Compare
gingerbenw
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's building and passing I'm happy - but review from @lemnik would be appreciated.
lemnik
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Respond to yesterday's JCenter outage.
Design
The intention of the code in
packages/react-native/android/build.gradle
was to shield our test fixture builds from JCenter outages, but it also unnecessarily adding a dependency on JCenter for app builds in general.Changeset
The build script snippet is now moved to only reside within our test fixture build scripts. The get all fixtures to build on CI during the (potentially partial) outage I found it necessary to replace
jcenter()
withmavenCentral()
in a number of locations, as well as removing Flipper from the builds (we don't need it anyway).Testing
Covered by CI.