Add extra validation steps and unit tests #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/maze/schemas/validator_base.rb
Outdated
Comment on lines
48
to
50
| elsif element.kind_of?(Array) && element.empty? | ||
| @success = false | ||
| @errors << "Element '#{path}' was an empty array" |
There was a problem hiding this comment.
I think this makes sense - we always consider empty arrays as "missing"? I can imagine that quirks in various platforms could cause an empty array to be serialised from "nothing".
There was a problem hiding this comment.
I've removed this, and have set it to allow arrays to be marked as present. Otherwise I can see this potentially being a tripping point as it's not obvious what's happening.
twometresteve
approved these changes
Sep 19, 2024
Cawllec
force-pushed
the
validation/extra-capabilities
branch
from
7298951 to
4b35357
Compare
twometresteve
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds some extra functions to shortcut a bunch of more complicated logic that had to be used in the Go tests.