Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Handing of HD Public Keys in Multisig TXs #85

Merged
merged 24 commits into from
Aug 11, 2021
Merged

Conversation

mflaxman
Copy link
Collaborator

@mflaxman mflaxman commented Aug 9, 2021

  • Add smart understanding of xpubs in PSBTs, so that output descriptors are not required to sign when these are properly supplied. Update multiwallet with this UX.
  • Modularize input and output description in PSBT class so that this can be applied to other script types (especially p2sh) in the future
  • (re)generalize from_hd_pub and from_hd_priv path handling (don't falsely specify root_path when xpub use-cases are base_path
  • Helper method to create a PSBT with hd_pubs and other metadata
  • More test coverage
  • Minor cleanup of previous codebase

@mflaxman mflaxman requested a review from jimmysong August 9, 2021 00:44
@mflaxman
Copy link
Collaborator Author

mflaxman commented Aug 9, 2021

This fixes #42

@mflaxman mflaxman merged commit bc5fd58 into main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant