Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate switch to clap v4.0 #3506

Closed
mrinalwadhwa opened this issue Sep 21, 2022 · 5 comments
Closed

Investigate switch to clap v4.0 #3506

mrinalwadhwa opened this issue Sep 21, 2022 · 5 comments
Labels
Component: Command good first issue hacktoberfest Apply to issues you want contributors to help with help wanted Implementation: Rust

Comments

@mrinalwadhwa
Copy link
Member

mrinalwadhwa commented Sep 21, 2022 •
edited
Loading

Clap now has a new release candidate

https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#migrating
https://epage.github.io/blog/2022/09/clap4/

We love helping new contributors!
If you have questions or need help as you work on your first Ockam contribution, please leave a comment on this discussion.
If you're looking for other issues to contribute to, checkout this discussion and labels - good first issue or help wanted

@mrinalwadhwa
Copy link
Member Author

#3434 has some good discussion on why we need it.

@hargut hargut mentioned this issue Sep 22, 2022
Closed
4 tasks
@hargut
Copy link
Contributor

hargut commented Sep 22, 2022

Hi all,

I've started to look a bit into the first steps of the upgrade, and linked a wip PR to the ticket. In case anyone wants to continue from here the first steps available.

Best regards,
Harald

@hargut hargut mentioned this issue Sep 24, 2022
Merged
4 tasks
@hargut
Copy link
Contributor

hargut commented Sep 27, 2022

@mrinalwadhwa
Is there anything else within this ticket that should be investigated or can it be closed?

Best regards,
Harald

@mrinalwadhwa
Copy link
Member Author

clap v4 was released a couple of days ago https://github.com/clap-rs/clap/releases
@hargut thanks to your fantastic PR last week, I think the final switch from the release candidate to the released version should be pretty simple.

@adrianbenavides adrianbenavides added the hacktoberfest Apply to issues you want contributors to help with label Oct 3, 2022
@adrianbenavides
Copy link
Member

adrianbenavides commented Oct 4, 2022 •
edited
Loading

I've created a new issue to address the upgrade to v.4.0 #3556

@adrianbenavides adrianbenavides mentioned this issue Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Command good first issue hacktoberfest Apply to issues you want contributors to help with help wanted Implementation: Rust
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrinalwadhwa @hargut @adrianbenavides