feat(rust): upgrade to clap v4 #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrinalwadhwa
force-pushed
the
feature/clap4-initial
branch
from
73c278d to
ec84594
Compare
mrinalwadhwa
previously approved these changes
Sep 26, 2022
There was a problem hiding this comment.
@hargut Thank you for another awesome Pull Request. The changes look great!
upgrade clap to v4.0.0.0-rc.2 & clap_complete to v4.0.0-rc.1 address v3 & v4 deprecation warnings transition derives to command/arg deactivate mut_subcommand for "help" (causes runtime error) disable_help_flag and add global help arg unify help templates with new default help styling (lower-/uppercase)
mrinalwadhwa
force-pushed
the
feature/clap4-initial
branch
from
ec84594 to
d6071b5
Compare
mrinalwadhwa
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
clap & clap_complete v3 are used
Proposed Changes
Notes
Changing the
abouttext for thehelpfor subcommands was removed as this is not possible with the new version utilizingmut_subcommand.Formatting and styling the help is no longer possible the same way as in v3.
clap::Command::help_templateformats the variables (e.g.{usage}) now with the new style (bold/underlined) but within the template there is no support for bold/underline in custom strings.Checks