Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 1.90.7 #20

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Bump version to 1.90.7 #20

merged 1 commit into from
Jun 3, 2024

Conversation

wroyca
Copy link
Contributor

@wroyca wroyca commented May 29, 2024

@Klaim Klaim requested a review from Rookfighter May 29, 2024 14:01
Rookfighter
Rookfighter reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@Rookfighter Rookfighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look alright, any idea why the windows MSVC builds fail?

@Klaim
Copy link
Contributor

Klaim commented May 29, 2024 •
edited
Loading

@Rookfighter See

So it should be fixed once glfw is fixed and it's package revision is published.

Rookfighter
Rookfighter approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@Rookfighter Rookfighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expecting the failed builds to be fixed with fixes of GLFW

@wroyca
Copy link
Contributor Author

wroyca commented Jun 3, 2024 •
edited
Loading

@Rookfighter The new GLFW revision is now available in stable, and all ImGui tests now pass properly 🎉

Rookfighter
Rookfighter approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@Rookfighter Rookfighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the GLFW package. Looks all good to me, CI is also happy 👍

@Rookfighter Rookfighter merged commit 53c14cc into build2-packaging:main Jun 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rookfighter Rookfighter Rookfighter approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wroyca @Klaim @Rookfighter