Change default_service_config to google.protobuf.Struct #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
force-pushed
the
eschouten/20250123-service-config
branch
2 times, most recently
from
da874c0 to
cca1c48
Compare
The gRPC service config is based on a Protobuf message structure defined here: https://github.com/grpc/grpc-proto/blob/master/grpc/service_config/service_config.proto Ideally we'd just embed grpc.service_config.ServiceConfig into this message, but that's easier said than done. There is no canonical Go module containing the generated Protobuf source files. Furthermore, grpc-go ships with some copies of those, but has them placed inside internal/. This means that even if we were to generate those ourselves, we'd run into a Protobuf registration conflict at runtime. Use google.protobuf.Struct, so that we can at least embed these service configs without requiring excessive quoting. This is a continuation of #236.
EdSchouten
force-pushed
the
eschouten/20250123-service-config
branch
from
cca1c48 to
c049384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC service config is based on a Protobuf message structure defined here:
https://github.com/grpc/grpc-proto/blob/master/grpc/service_config/service_config.proto
Ideally we'd just embed grpc.service_config.ServiceConfig into this message, but that's easier said than done. There is no canonical Go module containing the generated Protobuf source files.
Furthermore, grpc-go ships with some copies of those, but has them placed inside internal/. This means that even if we were to generate those ourselves, we'd run into a Protobuf registration conflict at runtime.
Use google.protobuf.Struct, so that we can at least embed these service configs without requiring excessive quoting.
This is a continuation of #236.