Cancelled jobs report an exit code of 0 on Windows

[keithduncan]

This is inconsistent with Linux (haven’t tested on macOS). We should make this behaviour the same across all operating systems.

[twometresteve]

Works fine for us here on macOS, but fixing it on Windows would be great - thank you.

[staticfloat]

I can confirm that this is occurring as well. If there's any need for debugging (we have a fleet of Windows VMs that we run in buildkite) I'd be happy to deploy changes for testing, etc...

[twometresteve]

After looking at this more, we came to the conclusion that it was down to the behaviour of Windows (try interrupting a running batch script and query the exit code - it's always 0). We just dodged the bullet enitely by using the Linux agent under WSL - to very good effect.

[JustinTether]

We're also running into this issue which has been causing some confusion when looking at a green cancelled step -- We found that we could get more accurate states by removing the artifact_paths keys from our steps and artifacting manually