Store experiments in contexts #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
experiments-in-context
branch
3 times, most recently
from
e90c6e3 to
c9c238c
Compare
DrJosh9000
changed the title
DrJosh9000
force-pushed
the
experiments-in-context
branch
2 times, most recently
from
e39c123 to
95fa8de
Compare
|
This is ready, if anyone wants to poke at it. |
DrJosh9000
force-pushed
the
experiments-in-context
branch
from
95fa8de to
1bbe285
Compare
triarius
reviewed
Aug 24, 2023
There was a problem hiding this comment.
This makes me so happy!
Just mainly, I think the move to internal can happen now. It's supposedly imported by ~~~2~~ 4 libraries, but that just looks like a fork of the agent.
Even if it's imported by real modules, there's legitimate reason modules outside the agent to use it.
| @@ -29,10 +29,10 @@ var commitPattern = bintest.MatchPattern(`(?ms)\Acommit [0-9a-f]+\nabbrev-commit | |||
| const gitShowFormatArg = "--format=commit %H%nabbrev-commit %h%nAuthor: %an <%ae>%n%n%w(0,4,4)%B" | |||
|
|
|||
| func TestWithResolvingCommitExperiment(t *testing.T) { | |||
| // t.Parallel() cannot be used with experiments.Enable() | |||
| defer experiments.EnableWithUndo(experiments.ResolveCommitAfterCheckout)() | |||
There was a problem hiding this comment.
Oh yeah, not needing this is a win too!
| // This context needs to be stored here in order to pass experiments to tests, | ||
| // because testing.M can only Run (without passing arguments or context). | ||
| // In ordinary code, pass contexts as arguments! | ||
| var mainCtx = context.Background() |
DrJosh9000
force-pushed
the
experiments-in-context
branch
from
1bbe285 to
a599ede
Compare
It was missing `tc := tc` in the loop. With that added, `post-checkout` failed consistently rather than rarely. (Looks like `post-checkout` shouldn't upload the artifact.)
DrJosh9000
force-pushed
the
experiments-in-context
branch
from
a599ede to
5be1f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is to associate experiments with contexts (as values). Enabling or disabling an experiment creates a new context.
Most code has context plumbed through correctly, so adopting it wasn't too hard. The bulk of the updates are to tests.
But now that experiments is not a "global variable", we can parallelise more tests!