Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing pipelines what use a string as the skip key in a matrix adjustment #2407

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix parsing pipelines what use a string as the skip key in a matrix adjustment #2407

merged 1 commit into from
Oct 3, 2023

Conversation

moskyb
Copy link
Contributor

@moskyb moskyb commented Oct 3, 2023

Also, demote SoftFail on matrix adjustments to being a RemainingField, as it's unused by the agent

@moskyb moskyb requested review from DrJosh9000 and triarius October 3, 2023 02:12
triarius
triarius reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@triarius triarius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've assumed ShouldSkip should have the same logic as what removes adjustments from the jobs array in the backend. I don't think it currently does.

internal/pipeline/step_command_matrix.go Outdated Show resolved Hide resolved
internal/pipeline/steps.go Outdated Show resolved Hide resolved
internal/pipeline/step_command_matrix.go Outdated Show resolved Hide resolved
@moskyb
Fix parsing pipelines what use a string as the skip key in a matrix a…
f6c41e1 
…djustment

Also, demote SoftFail on matrix adjustments to being a RemainingField, as it's unused by the agent
triarius
triarius approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@triarius triarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moskyb moskyb merged commit 8faa01f into main Oct 3, 2023
@moskyb moskyb deleted the fix-string-skips branch October 3, 2023 05:05
@triarius triarius mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triarius triarius triarius approved these changes

@DrJosh9000 DrJosh9000 Awaiting requested review from DrJosh9000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moskyb @triarius