Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verifying jobs with no plugins #2419

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix verifying jobs with no plugins #2419

merged 1 commit into from
Oct 10, 2023

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Oct 10, 2023 •
edited
Loading

jcs.Transform doesn't like empty strings or null. This also changes the error strings to be a bit more direct about what was compared (instead of talking about "fields").

@DrJosh9000
Fix verifying jobs with no plugins
ccaf7b3 
`jcs.Transform` doesn't like empty strings or `null`.
@DrJosh9000 DrJosh9000 requested a review from moskyb October 10, 2023 02:51
@DrJosh9000 DrJosh9000 merged commit 6df9d0c into main Oct 10, 2023
@DrJosh9000 DrJosh9000 deleted the pdp-1763-i-know-kung-fu branch October 10, 2023 03:07
@moskyb moskyb mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moskyb moskyb moskyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @moskyb