Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning about short vars once #2454

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Log warning about short vars once #2454

merged 1 commit into from
Oct 25, 2023

Conversation

DrJosh9000
Copy link
Contributor

As opposed to a log line per short variable.

@DrJosh9000 DrJosh9000 requested a review from a team October 25, 2023 01:14
moskyb
moskyb reviewed Oct 25, 2023
View reviewed changes
internal/redact/redact.go Outdated Show resolved Hide resolved
moskyb
moskyb approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! what a turnaround time 🥳

@DrJosh9000
Log warning about short vars once
3c37060 
As opposed to a log line per short variable.
@DrJosh9000 DrJosh9000 force-pushed the combine-redactor-warning branch from 5a1968b to 3c37060 Compare October 25, 2023 02:09
@DrJosh9000 DrJosh9000 enabled auto-merge October 25, 2023 02:13
@DrJosh9000 DrJosh9000 merged commit fc11f57 into main Oct 25, 2023
@DrJosh9000 DrJosh9000 deleted the combine-redactor-warning branch October 25, 2023 05:24
@DrJosh9000 DrJosh9000 mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moskyb moskyb moskyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @moskyb