Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use os.RemoveAll in cleanup #2538

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

DrJosh9000
Copy link
Contributor

Because the tests are parallel, using the same directory would cause flakes. So also use a different directory for each test.

@DrJosh9000 DrJosh9000 requested a review from triarius December 4, 2023 23:10
Copy link
Contributor

@triarius triarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up (even more) after me!

internal/tempfile/tempfile_test.go Outdated Show resolved Hide resolved
internal/tempfile/tempfile_test.go Outdated Show resolved Hide resolved
DrJosh9000 and others added 2 commits December 5, 2023 10:21

Verified

This commit was signed with the committer’s verified signature.
DrJosh9000 Josh Deprez
Because the tests are parallel, using the same directory would cause flakes. So also use a different directory for each test.

Partially verified

This commit is signed with the committer’s verified signature.
DrJosh9000’s contribution has been verified via SSH key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Narthana Epa <[email protected]>
@DrJosh9000 DrJosh9000 force-pushed the tempfile-test-cleanup-removeall branch from 26939c2 to aff59a2 Compare December 4, 2023 23:21
@DrJosh9000 DrJosh9000 merged commit a5de7a8 into main Dec 4, 2023
@DrJosh9000 DrJosh9000 deleted the tempfile-test-cleanup-removeall branch December 4, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants