-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more debug logging and error wrapping for running processes #2543
Add more debug logging and error wrapping for running processes #2543
Conversation
A customer is seeing errors trying to start a process on an exotic platform that we currently don't support. Currently, they are getting an error from (*Process).Run. Lets add some debug logging and error wrapping to see what's going on.
err = nil | ||
} | ||
switch { | ||
case errors.Is(err, syscall.EIO): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess technically this catches errors that are not os.PathError
that also happen to wrap syscall.EIO
. I think it's unlikely that io.Copy
will create such a thing, but I'm happy to do a more specific unwrap if we think otherwise.
@triarius Hey, I now see this in the log in the Pipelines page on the site.
The build script I'm using is this |
@v1gnesh pty is optional, we disable it on windows: Lines 370 to 374 in e32d495
Starting the agent with |
Oh that's a nice option. Although the upstream Go compiler has these keywords reserved, the OS's bits haven't fully been upstreamed yet. |
@triarius I've successfully run the sample pipeline and all green on the BK site ❤️ |
A customer is seeing errors trying to start a process on an exotic platform that we currently don't support. They are getting an error from
(*Process).Run
. Let's add some debug logging and error wrapping to see what's going on.