Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better plugin checkout logging #3166

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Better plugin checkout logging #3166

merged 1 commit into from
Jan 27, 2025
+7 −3

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Jan 23, 2025 •
edited
Loading

Description

Fixes #3090

Changes

  • Change the temp directory pattern to be less reminiscent of a plugin directory
  • Log the mktemp and mv operations similarly to the cd operation

To think about: these new logged operations should probably appear different on Windows 🤔

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

wolfeidau
wolfeidau approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@wolfeidau wolfeidau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 NICE, I also found this confusing.

@DrJosh9000 DrJosh9000 merged commit bf68b2d into main Jan 27, 2025
1 check passed
@DrJosh9000 DrJosh9000 deleted the better-plugin-checkout-logging branch January 27, 2025 23:55
@DrJosh9000 DrJosh9000 mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfeidau wolfeidau wolfeidau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: plugin checkout dir printed incorrectly
2 participants
@DrJosh9000 @wolfeidau