Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate .d.cts files alongside .d.ts files. #555

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Generate .d.cts files alongside .d.ts files. #555

merged 1 commit into from
Mar 20, 2023

Conversation

gabro
Copy link
Member

@gabro gabro commented Mar 17, 2023

This is a workaround for egoist/tsup#579 and more generally for the problems highlighted in this thread https://twitter.com/atcb/status/1634653474041503744?s=61&t=nC5rArtZAYIRm7854OZMDw

Manually checked here using https://arethetypeswrong.github.io/

Here's the result after the current PR

image

Here's how it is currently

image

@kanbanbot kanbanbot added the WIP label Mar 17, 2023
@vercel
Copy link

vercel bot commented Mar 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
bento-docs ✅ Ready (Inspect) Visit Preview Mar 17, 2023 at 6:07PM (UTC)
bento-playroom ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 6:07PM (UTC)

Copy link
Member

@veej veej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gabro gabro merged commit e9e1263 into main Mar 20, 2023
@gabro gabro deleted the esm-patch-ts branch March 20, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants