Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make webhook secret and service name configurable #688

Open
sambhav opened this issue May 8, 2021 · 0 comments
Open

Make webhook secret and service name configurable #688

sambhav opened this issue May 8, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@sambhav
Copy link
Contributor

sambhav commented May 8, 2021

The kpack webhook hardcodes a bunch of values. These could be passed as config - for eg -

https://github.com/tektoncd/triggers/blob/a545f76e7f0021ee13a1c22b6703dae18d2639fa/cmd/webhook/main.go#L104

See knative/eventing#4530

@matthewmcnew matthewmcnew added the enhancement New feature or request label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants