Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote WEBHOOK_NAME convention, use consistently across knative #4530

Closed
mattmoor opened this issue Nov 16, 2020 · 3 comments · Fixed by #4575
Closed

Promote WEBHOOK_NAME convention, use consistently across knative #4530

mattmoor opened this issue Nov 16, 2020 · 3 comments · Fixed by #4575
Assignees
Labels
area/api kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature-request kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@mattmoor
Copy link
Member

Problem

Eventing defines and uses:

func WebhookName() string {

Persona:

Contributor

Exit Criteria

Knative consistently defines/uses WEBHOOK_NAME.

Time Estimate (optional):

1 to move to PKG and cleanup eventing.
2-3 to cleanup the rest of Knative.

Additional context (optional)

This is probably also relevant to Tekton cc @afrittoli

@grantr grantr added area/api kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 16, 2020
@grantr grantr added this to the Backlog milestone Nov 16, 2020
@arghya88
Copy link
Contributor

@mattmoor
Copy link
Member Author

Yeah, that SGTM

@arghya88
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature-request kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants