Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyze fails checking nonexistent manifest on harbor 2 #303

Closed
matthewmcnew opened this issue May 27, 2020 · 1 comment · Fixed by #304
Closed

Analyze fails checking nonexistent manifest on harbor 2 #303

matthewmcnew opened this issue May 27, 2020 · 1 comment · Fixed by #304
Labels
type/bug Something isn't working
Milestone
lifecycle-0.8.0

Comments

@matthewmcnew
Copy link
Contributor

Summary

The analyze step fails when checking if a non-existant image exists on a harbor 2 registry.

[analyze] ERROR: failed to get previous image: connect to repo store 'some.harbor.2.org/demo/spring-music:v2': GET https://some.harbor.2.org/v2/demo/spring-music/manifests/v2: NOT_FOUND: artifact demo/spring-music:v2 not found
lifecycle version:

v0.7.2
@matthewmcnew matthewmcnew added type/bug Something isn't working status/triage labels May 27, 2020
@matthewmcnew
Copy link
Contributor Author

Found by: @agapebondservant

matthewmcnew added a commit to matthewmcnew/imgutil that referenced this issue May 27, 2020
@matthewmcnew
Gracefully handle any 404 status code when fetching images
e22d3dc 
- Harbor 2 appears to return unexpected Code "NOT_FOUND" with a 404
- buildpacks/lifecycle#303
matthewmcnew added a commit to matthewmcnew/imgutil that referenced this issue May 27, 2020
@matthewmcnew
Gracefully handle any 404 status code when fetching images
371abe8 
- Harbor 2 appears to return unexpected Code "NOT_FOUND" with a 404
- buildpacks/lifecycle#303
@matthewmcnew matthewmcnew mentioned this issue May 27, 2020
Merged
matthewmcnew added a commit to matthewmcnew/imgutil that referenced this issue May 27, 2020
@matthewmcnew
Gracefully handle any 404 status code when fetching images
26b72fe 
- Harbor 2 appears to return unexpected Code "NOT_FOUND" with a 404
- buildpacks/lifecycle#303

Signed-off-by: Matthew McNew <[email protected]>
@ekcasey ekcasey mentioned this issue May 28, 2020
Merged
@ekcasey ekcasey added this to the lifecycle-0.8.0 milestone Jun 1, 2020
@matthewmcnew matthewmcnew mentioned this issue Jun 16, 2020
Closed
@ekcasey ekcasey mentioned this issue Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
lifecycle-0.8.0
Development

Successfully merging a pull request may close this issue.

Handle 404s from harbor buildpacks/lifecycle
2 participants
@matthewmcnew @ekcasey