Lifecycle only gets remote or local image, without concern for pulling #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashwin-venkatesh @joaopapereira I wonder if it makes sense to take the pulling logic out of I'm thinking about the pull logs and this upcoming bug buildpacks/roadmap#49, both of which would be less complicated if the pull logic lived in pack Additionally I'm worried that pack might print confusing logs if it can't determine whether the image was pulled or not. |
sclevine
previously requested changes
Mar 7, 2019
ameyer-pivotal
changed the title
- We want to ensure that lifecycle does not return an error in the situation where we can pull from remote but the image only exists locally [buildpacks/pack#90] Signed-off-by: Joao Pereira <[email protected]> Signed-off-by: Ashwin Venkatesh <[email protected]> Signed-off-by: Andrew Meyer <[email protected]>
Signed-off-by: Joao Pereira <[email protected]> Signed-off-by: Andrew Meyer <[email protected]>
Signed-off-by: Andrew Meyer <[email protected]>
Signed-off-by: Andrew Meyer <[email protected]>
ameyer-pivotal
force-pushed
the
fix-issue-pack90
branch
from
0b80953 to
1551381
Compare
ameyer-pivotal
dismissed
sclevine’s stale review
Issues addressed or outdated. Please take another look now.
ameyer-pivotal
requested review from
ameyer-pivotal
and removed request for
ameyer-pivotal
sclevine
approved these changes
Mar 11, 2019
Signed-off-by: Andrew Meyer <[email protected]>
ameyer-pivotal
force-pushed
the
fix-issue-pack90
branch
from
42ef23c to
1374c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
situation where we can pull from remote but the image only exists
locally
[buildpacks/pack#90]