Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pack warns about valid clear-env key in buildpack.toml #2253

Closed
edmorley opened this issue Aug 28, 2024 · 1 comment · Fixed by #2261
Closed

Pack warns about valid clear-env key in buildpack.toml #2253

edmorley opened this issue Aug 28, 2024 · 1 comment · Fixed by #2261
Labels
good first issue A good first issue to get started with. help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.

Comments

@edmorley
Copy link
Contributor

Summary

Similar to #2192, Pack CLI gives an incorrect warning about a valid buildpack.toml key, but this time it's the clear-env key, which is allowed in the spec:
https://github.com/buildpacks/spec/blob/main/buildpack.md#buildpacktoml-toml

Reproduction

Steps
  1. Create a buildpack whose buildpack.toml contains: 
    api = "0.11"

[buildpack]
id = "testing-buildpack"
version = "0.0.0"
clear-env = true
  2. pack build --builder heroku/builder:24 --buildpack <path_to_that_buildpack>
Current behavior
Warning: Ignoring unexpected key(s) in descriptor for buildpack testing-buildpack: buildpack.clear-env
===> ANALYZING
...
Expected behavior

No warning about an unexpected clear-env key.

Environment

pack info

Pack CLI v0.35.1
lifecycle 0.20.1
@edmorley edmorley added status/triage Issue or PR that requires contributor attention. type/bug Issue that reports an unexpected behaviour. labels Aug 28, 2024
@jjbustamante jjbustamante added help wanted Need some extra hands to get this done. good first issue A good first issue to get started with. status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels Aug 28, 2024
fumblehool added a commit to fumblehool/pack that referenced this issue Sep 8, 2024
@fumblehool
Don't warn about clear-env key while parsing buildpack.toml as this i…
b277e64 
…s actually expected.

Fixes buildpacks#2253
@fumblehool fumblehool mentioned this issue Sep 8, 2024
Merged
2 tasks
fumblehool added a commit to fumblehool/pack that referenced this issue Sep 8, 2024
@fumblehool
Don't warn about clear-env key while parsing buildpack.toml as this i…
c4c27b1 
…s actually expected.

Fixes buildpacks#2253

Signed-off-by: Damanpreet Singh <[email protected]>
@edmorley
Copy link
Contributor Author

@fumblehool Thank you for fixing this! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good first issue to get started with. help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
No milestone
2 participants
@edmorley @jjbustamante